Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix goreleaser --skip-publish flag deprecation #121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix goreleaser --skip-publish flag deprecation #121

wants to merge 1 commit into from

Conversation

mjlshen
Copy link

@mjlshen mjlshen commented Oct 8, 2024 •
edited
Loading

  • --skip-publish was replaced with --skip=publish
  • --rm-dist was replaced with --clean

https://goreleaser.com/deprecations/#-skip
https://goreleaser.com/deprecations/#-rm-dist

This resolves the CI failure in #120

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 8, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2024
@mjlshen
Fix goreleaser flag deprecations
6a898a5 
* --skip-publish was replaced with --skip=publish
* --rm-dist was replaced with --clean

https://goreleaser.com/deprecations/#-skip
https://goreleaser.com/deprecations/#-rm-dist

Signed-off-by: Michael Shen <[email protected]>
@mjlshen mjlshen mentioned this pull request Oct 8, 2024
Open
@kmala
Copy link

kmala commented Oct 15, 2024

/lgtm

@k8s-ci-robot
Copy link
Contributor

@kmala: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mjlshen
Copy link
Author

mjlshen commented Oct 24, 2024

@xdu31 / @wongma7 Do either of you have cycles to review this?

@kmala
Copy link

kmala commented Nov 1, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2024
@kmala
Copy link

kmala commented Nov 1, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kmala, mjlshen
Once this PR has been reviewed and has the lgtm label, please assign wongma7 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wongma7 wongma7 Awaiting requested review from wongma7

@xdu31 xdu31 Awaiting requested review from xdu31

Assignees

@kmala kmala

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjlshen @kmala @k8s-ci-robot